[webkit-reviews] review requested: [Bug 29069] [HTML5][Forms] min/max attributes support for type=number : [Attachment 40679] Proposed patch (rev.7)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 5 19:43:17 PDT 2009


TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 29069: [HTML5][Forms] min/max attributes support for type=number
https://bugs.webkit.org/show_bug.cgi?id=29069

Attachment 40679: Proposed patch (rev.7)
https://bugs.webkit.org/attachment.cgi?id=40679&action=review

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>
Fixed the build problems on Windows.
 - Initialize local variables with 0.0
 - Not define max/min for COM to avoid conflict in WebKit.h
   I think to add "#define NOMINMAX" to WebKit.h is the right fix.  But I
couldn't find who generates WebKit.h.


More information about the webkit-reviews mailing list