[webkit-reviews] review requested: [Bug 30102] [Win] Drag cursor does not show not-allowed cursor on invalid drag-and-drop operation. : [Attachment 40674] Patch with manual test case

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 30102: [Win] Drag cursor does not show not-allowed cursor on invalid
drag-and-drop operation.
https://bugs.webkit.org/show_bug.cgi?id=30102

Attachment 40674: Patch with manual test case
https://bugs.webkit.org/attachment.cgi?id=40674&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
I could not think of a good name for the function
draggingSourceOperationMaskToDragCursors in file WebDragClient.cpp. I am open
to suggestions.

We cannot test this using DRT because DRT looks at the programmatic drop cursor
and until bug #24731 is fixed this value is hard-coded to DragOperationCopy.
That is, there is a discrepancy in the Windows build between the Windows
API-based drop effect and the WebKit drop effect. Because DRT cannot read the
screen buffer to determine the cursor, a manual test is needed.