[webkit-reviews] review denied: [Bug 26856] AnchorElement, ButtonElement, InputButton and Document should fire focus event when it is clicked. : [Attachment 40659] patch

[bugzilla-daemon at webkit.org]

Erik Arvidsson <arv at chromium.org> has denied Chang Shu <Chang.Shu at nokia.com>'s
request for review:
Bug 26856: AnchorElement, ButtonElement, InputButton and Document should fire
focus event when it is clicked.
https://bugs.webkit.org/show_bug.cgi?id=26856

Attachment 40659: patch
https://bugs.webkit.org/attachment.cgi?id=40659&action=review

------- Additional Comments from Erik Arvidsson <arv at chromium.org>
Although this patch gives the right behavior I think we need to be a bit
careful here.

With this patch links gets the focus outline when the user clicks them. This is
correct when it comes to CSS because we have something like :link:focus {
outline: ...}. However, I doubt that we want this heavy visual clutter on links
by default.

You can remove isMouseFocusable from HTMLAnchorElement now since all it does is
call super.

Also, you need to include a layout test with your patch.