[webkit-reviews] review denied: [Bug 30076] Header files of WebKitGTK do not comply with WebKit coding style (Patch attached) : [Attachment 40633] WebKitGtkHeaders.patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 5 12:58:51 PDT 2009


Xan Lopez <xan.lopez at gmail.com> has denied  review:
Bug 30076: Header files of WebKitGTK do not comply with WebKit coding style
(Patch attached)
https://bugs.webkit.org/show_bug.cgi?id=30076

Attachment 40633: WebKitGtkHeaders.patch
https://bugs.webkit.org/attachment.cgi?id=40633&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
>-#ifndef WEBKIT_SOUP_AUTH_DIALOG_H
>-#define WEBKIT_SOUP_AUTH_DIALOG_H 1
>+#ifndef webkitsoupauthdialog_h
>+#define webkitsoupauthdialog_h 1

While we are at it, can we get rid of that '1' too?

You need to provide a ChangeLog as mentioned in the contributing document,
using the prepare-ChangeLog script. Marking r- (also, you need to mark patches
for review when attaching :))


More information about the webkit-reviews mailing list