[webkit-reviews] review requested: [Bug 30048] [Qt] mouseUp() and mouseDown() in EventSender ignore the button argument : [Attachment 40645] patch

[bugzilla-daemon at webkit.org]

Jakub Wieczorek <faw217 at gmail.com> has asked  for review:
Bug 30048: [Qt] mouseUp() and mouseDown() in EventSender ignore the button
argument
https://bugs.webkit.org/show_bug.cgi?id=30048

Attachment 40645: patch
https://bugs.webkit.org/attachment.cgi?id=40645&action=review

------- Additional Comments from Jakub Wieczorek <faw217 at gmail.com>
(In reply to comment #2)
> (From update of attachment 40581 [details])
> What is the NoButton default useful for?  And why don't we assert() that it's

> not called?  Or are there reasons why mouseDown(3) should silently "fail"?
> 
> This should list tests which it fixes (assuming the list is relatively
short). 
> But in general it looks fine.  r- for the possible NoButton confusion. 
Please
> explain why NoButton is correct there.

Right, NoButton does not make much sense. I took a look at the EventSender from
the Windows port and changed the patch to do something similar.

So mouseDown(3) will send a middle button event and the fallback button will be
the left button.