[webkit-reviews] review requested: [Bug 29832] Crash in DOMWindow::clearTimeout etc when DOMWindow is not connected to frame : [Attachment 40644] Proposed fix.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 5 10:58:40 PDT 2009


Dmitry Titov <dimich at chromium.org> has asked  for review:
Bug 29832: Crash in DOMWindow::clearTimeout etc when DOMWindow is not connected
to frame
https://bugs.webkit.org/show_bug.cgi?id=29832

Attachment 40644: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=40644&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
I think this might be a fix. Clearing WindowShell after Frame disconnects from
DOMWindow (and renders it unable to execute most JS callbacks) will clear
global script data and cause re-resolution of properties. I can't think of a
DRT test for that, the one I have takes ~10 seconds to run which is too long.


More information about the webkit-reviews mailing list