[webkit-reviews] review denied: [Bug 30033] [chromium] DateExtension has reliability bot crashes : [Attachment 40642] Updated per review comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 5 10:57:53 PDT 2009


Adam Barth <abarth at webkit.org> has denied John Abd-El-Malek
<jam at chromium.org>'s request for review:
Bug 30033: [chromium] DateExtension has reliability bot crashes
https://bugs.webkit.org/show_bug.cgi?id=30033

Attachment 40642: Updated per review comments
https://bugs.webkit.org/attachment.cgi?id=40642&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
We should add a test for the crash.

+ v8::Local<v8::Value> result =
V8Proxy::retrieve()->evaluate(WebCore::ScriptSourceCode("Date"), 0);

This seems overly complicated.	Why not just get the "Date" property of the
context's global object?

Other than those two issue, this looks reasonable.


More information about the webkit-reviews mailing list