[webkit-reviews] review granted: [Bug 30077] Add an ASSERT in updateGuidVersionMap. : [Attachment 40639] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 5 10:16:18 PDT 2009
Darin Adler <darin at apple.com> has granted Ben Murdoch <benm at google.com>'s
request for review:
Bug 30077: Add an ASSERT in updateGuidVersionMap.
https://bugs.webkit.org/show_bug.cgi?id=30077
Attachment 40639: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=40639&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> // NOTE: Caller must lock guidMutex().
> static inline void updateGuidVersionMap(int guid, String newVersion)
> {
> + // Ensure the the mutex is locked.
> + ASSERT(!guidMutex().tryLock());
I wish there was some way to merge those two comments into one!
r=me
More information about the webkit-reviews
mailing list