[webkit-reviews] review requested: [Bug 30044] [Qt] EventSender::keyDown() cannot send function-key events. : [Attachment 40638] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 5 09:59:25 PDT 2009
Jakub Wieczorek <faw217 at gmail.com> has asked for review:
Bug 30044: [Qt] EventSender::keyDown() cannot send function-key events.
https://bugs.webkit.org/show_bug.cgi?id=30044
Attachment 40638: patch
https://bugs.webkit.org/attachment.cgi?id=40638&action=review
------- Additional Comments from Jakub Wieczorek <faw217 at gmail.com>
(In reply to comment #2)
> (From update of attachment 40573 [details])
> Looks OK, but the ChangeLog should say what layout test this fixes.
The patch itself does not fix the above mentioned test failure because there's
one more bug in Qt DRT that makes the test fail:
https://bugs.webkit.org/show_bug.cgi?id=30043
I've also added ' && functionKey <= 35' to the assertion, just in case.
More information about the webkit-reviews
mailing list