[webkit-reviews] review denied: [Bug 30048] [Qt] mouseUp() and mouseDown() in EventSender ignore the button argument : [Attachment 40581] patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Jakub Wieczorek <faw217 at gmail.com>'s
request for review:
Bug 30048: [Qt] mouseUp() and mouseDown() in EventSender ignore the button
argument
https://bugs.webkit.org/show_bug.cgi?id=30048

Attachment 40581: patch
https://bugs.webkit.org/attachment.cgi?id=40581&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
What is the NoButton default useful for?  And why don't we assert() that it's
not called?  Or are there reasons why mouseDown(3) should silently "fail"?

This should list tests which it fixes (assuming the list is relatively short). 
But in general it looks fine.  r- for the possible NoButton confusion.	Please
explain why NoButton is correct there.