[webkit-reviews] review denied: [Bug 29157] [Qt] Add the ability to specify the mkspec when building with qmake : [Attachment 39387] patch for webkitdirs.pm

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has denied Simon Hausmann
<hausmann at webkit.org>'s request for review:
Bug 29157: [Qt] Add the ability to specify the mkspec when building with qmake
https://bugs.webkit.org/show_bug.cgi?id=29157

Attachment 39387: patch for webkitdirs.pm
https://bugs.webkit.org/attachment.cgi?id=39387&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
Hmm, you should be able to set the spec already using --qmakearg="-spec
macx-llvm", or using the QMAKESPEC environment variable.

The only thing your patch does as far as I can tell is it makes sure we read
the correct spec when determining whether to use nmake or make to build.
If you want to support that I'd init the spec to $ENV{"QMAKESPEC"} || "default"
in buildQMakeProject() and then pull out the spec on line 1290 if the arg is
-spec, and then
pass that on to qtMakeCommand(). Also, you can do my ($qmakebin, $spec) = @_;