[webkit-reviews] review denied: [Bug 30062] Inspector should syntax highlight JS/CSS in elements view : [Attachment 40600] Fix Take 2

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 30062: Inspector should syntax highlight JS/CSS in elements view
https://bugs.webkit.org/show_bug.cgi?id=30062

Attachment 40600: Fix Take 2
https://bugs.webkit.org/attachment.cgi?id=40600&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +		       info.title ="\"<span>" + newNode.innerHTML +
"</span>\"";
> +		       info.title ="\"<span>" + newNode.innerHTML +
"</span>\"";

You should put class=\"webkit-html-text-node\" on these spans too. Missing a
space after the "=".

> +		   } else if (this.parentNode &&
this.parentNode.nodeName.toLowerCase().escapeHTML() == "style") {

No need for .escapeHTML(), since it will never have HTML characters.

Try adding "white-space: pre" to the webkit-html-text-node class, and see if
that preserves line breaks. It might break things, but worth a try.