[webkit-reviews] review denied: [Bug 29500] Reduce memory usage of WebCore::StringImpl : [Attachment 40541] patch #3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 2 17:03:27 PDT 2009


David Levin <levin at chromium.org> has denied Jens Alfke <snej at chromium.org>'s
request for review:
Bug 29500: Reduce memory usage of WebCore::StringImpl
https://bugs.webkit.org/show_bug.cgi?id=29500

Attachment 40541: patch #3
https://bugs.webkit.org/attachment.cgi?id=40541&action=review

------- Additional Comments from David Levin <levin at chromium.org>
The changelog is out of date in several aspects.

1. It doesn't mention anything about moving "unsigned m_length;"

2.
> +	   (WebCore::StringImpl::createUninitialized): Use new m_buffer member
to make the code
> +	       a little bit clearer.

Actually this isn't correct according to your comments in the bug.

3. It has several comments about functions no longer modified.

Perhaps other things that I didn't catch. It would be good to go over it and
bring it up to date.


More information about the webkit-reviews mailing list