[webkit-reviews] review denied: [Bug 29980] Loading invalid image crashes in RenderImage::setImageSizeForAltText : [Attachment 40555] the test case
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 2 15:57:04 PDT 2009
Eric Seidel <eric at webkit.org> has denied Yong Li <yong.li at torchmobile.com>'s
request for review:
Bug 29980: Loading invalid image crashes in RenderImage::setImageSizeForAltText
https://bugs.webkit.org/show_bug.cgi?id=29980
Attachment 40555: the test case
https://bugs.webkit.org/attachment.cgi?id=40555&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
These patches should all be one. invalid.jpg should be simpler (no need to be
a full html page, or?)
You don't actually need all this extra HTML boilerplate:
+<html>
+<head>
+ <title></title>
You just need a little text to describe and the <img>, you file does not need
to be valid HTML, it's better to be concise than valid.
More information about the webkit-reviews
mailing list