[webkit-reviews] review requested: [Bug 30021] check-webkit-style does not detect missing spaces around &=, |=, -=, and += : [Attachment 40548] Proposed patch

[bugzilla-daemon at webkit.org]

Carol Szabo <carol.szabo at nokia.com> has asked  for review:
Bug 30021: check-webkit-style does not detect missing spaces around &=, |=, -=,
and +=
https://bugs.webkit.org/show_bug.cgi?id=30021

Attachment 40548: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=40548&action=review

------- Additional Comments from Carol Szabo <carol.szabo at nokia.com>
Added some unit tests, but I think the best test is the fact that over the
entire existing WebKit codebase, there is no change in the output of the tool
introduced by my changes.
This means that at least my change is very unlikely to hide common errors that
were previously detected and very unlikely to introduce a lot of annoying false
errors.
My recorded unit tests as well as running the tool on my own patches proves
that it finds a few things that were  not found before.
By the way, I noticed that check-webkit-style is intentionally coded to allow
constructs such as a = 3<<4; This exception from the normal "binary operator
rule" is not mentioned in the coding styles webpage or I have missed it
(http://webkit.org/coding/coding-style.html). Also, another exception is if
((a=b) != c) construction where a comment in the check-webkit-style file says
that there must NOT be spaces around = inside if. This exception is not
mentioned in the guidelines either.