[webkit-reviews] review denied: [Bug 29803] [Qt] QWebHistory and QWebPage autotests crash : [Attachment 40432] optimization

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 2 12:37:33 PDT 2009


Eric Seidel <eric at webkit.org> has denied jedrzej.nowacki at nokia.com's request
for review:
Bug 29803: [Qt] QWebHistory and QWebPage autotests crash
https://bugs.webkit.org/show_bug.cgi?id=29803

Attachment 40432: optimization
https://bugs.webkit.org/attachment.cgi?id=40432&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Why:
     m_mainFrame->setView(0);
 172	 if (m_mainFrame)
 173	     m_mainFrame->setView(0);
That needs to be explained in the ChangeLog and possibly a comment.

Also, this needs a test.


More information about the webkit-reviews mailing list