[webkit-reviews] review denied: [Bug 30009] Web Inspector: close inspector client view on InspectorController::close API call. : [Attachment 40508] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 2 11:08:59 PDT 2009
Timothy Hatcher <timothy at hatcher.name> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 30009: Web Inspector: close inspector client view on
InspectorController::close API call.
https://bugs.webkit.org/show_bug.cgi?id=30009
Attachment 40508: patch
https://bugs.webkit.org/attachment.cgi?id=40508&action=review
------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> Page* WebInspectorClient::createPage()
> {
> - if (m_webView)
> - return core(m_webView.get());
> -
> ASSERT(!m_hwnd);
>
> registerWindowClass();
That !m_hwnd ASSERT will fire the second time.
More information about the webkit-reviews
mailing list