[webkit-reviews] review denied: [Bug 30018] WebGL crashes with recent CanvasArray change : [Attachment 40526] Patch including test case

Fri Oct 2 09:52:10 PDT 2009

Oliver Hunt <oliver at apple.com> has denied Kenneth Russell <kbr at google.com>'s
request for review:
Bug 30018: WebGL crashes with recent CanvasArray change
https://bugs.webkit.org/show_bug.cgi?id=30018

Attachment 40526: Patch including test case
https://bugs.webkit.org/attachment.cgi?id=40526&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>

> +<html xmlns="http://www.w3.org/1999/xhtml">
we don't use namespaces -- tests should basically be html5 doctype if you want
strict mode.  But in this case you're also using the xml namespace which is
also incorrect due to the file extension not being .xhtml, and not having an
xml doctype :D

And you need expected output

Cheers,
  Oliver