[webkit-reviews] review requested: [Bug 29133] Allow the platform media player to know the <video> poster URL. : [Attachment 40527] Add prepareToPlay(), setPoster() and canLoadPoster() methods to the MediaPlayer class and MediaPlayerPrivate iface. (take 3)

[bugzilla-daemon at webkit.org]

Andrei Popescu <andreip at google.com> has asked  for review:
Bug 29133: Allow the platform media player to know the <video> poster URL.
https://bugs.webkit.org/show_bug.cgi?id=29133

Attachment 40527: Add prepareToPlay(), setPoster() and canLoadPoster() methods
to the MediaPlayer class and MediaPlayerPrivate iface. (take 3)
https://bugs.webkit.org/attachment.cgi?id=40527&action=review

------- Additional Comments from Andrei Popescu <andreip at google.com>
Hi Eric,

Sorry for the late reply on this, it's only today that I got a chance to upload
a new patch.

As we discussed, I have added a method that is called when the state of
HTMLMediaElement is 'readyToPlay' but the media backend doesn't yet have enough
data. This is the case with our backend that does not prebuffer any content.
This allows the state to be correct from the beginning (NetworkState::Empty and
ReadyState::HaveNothing) and allows the backend to change the network and ready
states just before playback.

I left the setPoster method where it was in the first patch. Before playback,
it's WebCore that draws the poster. After playback, it's the MediaPlayerPrivate
that draws the poster in its paint method.

All the best,
Andrei