[webkit-reviews] review denied: [Bug 29653] [Qt] Qt-based browser fails to show the right language translation : [Attachment 40517] patch with new test case

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 2 09:02:12 PDT 2009


Simon Hausmann <hausmann at webkit.org> has denied Chang Shu
<Chang.Shu at nokia.com>'s request for review:
Bug 29653: [Qt] Qt-based browser fails to show the right language translation
https://bugs.webkit.org/show_bug.cgi?id=29653

Attachment 40517: patch with new test case
https://bugs.webkit.org/attachment.cgi?id=40517&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I agree that the Qt implementation is not correct, but I don't think "en-US" is
the correct value.

We should be using QLocale, just like the other ports are also returning
variable values instead of hard-coding "en-US".


More information about the webkit-reviews mailing list