[webkit-reviews] review requested: [Bug 29970] [Qt] Missing layoutTestController.overridePreference() implementation : [Attachment 40523] Implement the missing function

[bugzilla-daemon at webkit.org]

Jakub Wieczorek <faw217 at gmail.com> has asked  for review:
Bug 29970: [Qt] Missing layoutTestController.overridePreference()
implementation
https://bugs.webkit.org/show_bug.cgi?id=29970

Attachment 40523: Implement the missing function
https://bugs.webkit.org/attachment.cgi?id=40523&action=review

------- Additional Comments from Jakub Wieczorek <faw217 at gmail.com>
(In reply to comment #4)
> (From update of attachment 40459 [details])
> Great stuff, but I suggest to simplify the implmeneitation:
> 
> Store the defaults in QWebSettings::globalSettings(), make
overridePreferece()
> set the settings on the page's settings object and make resetSEttings() use
> resetAttribute, resetFontSize(), etc. to trigger the fallback to the global
> settings.

Sounds good, done.