[webkit-reviews] review denied: [Bug 29970] [Qt] Missing layoutTestController.overridePreference() implementation : [Attachment 40459] Implement the missing function

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Jakub Wieczorek
<faw217 at gmail.com>'s request for review:
Bug 29970: [Qt] Missing layoutTestController.overridePreference()
implementation
https://bugs.webkit.org/show_bug.cgi?id=29970

Attachment 40459: Implement the missing function
https://bugs.webkit.org/attachment.cgi?id=40459&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Great stuff, but I suggest to simplify the implmeneitation:

Store the defaults in QWebSettings::globalSettings(), make overridePreferece()
set the settings on the page's settings object and make resetSEttings() use
resetAttribute, resetFontSize(), etc. to trigger the fallback to the global
settings.