[webkit-reviews] review requested: [Bug 25526] [Gtk] Additional support is needed for caret browsing : [Attachment 40506] caret-cleanup.diff
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 2 04:01:09 PDT 2009
Xan Lopez <xan.lopez at gmail.com> has asked for review:
Bug 25526: [Gtk] Additional support is needed for caret browsing
https://bugs.webkit.org/show_bug.cgi?id=25526
Attachment 40506: caret-cleanup.diff
https://bugs.webkit.org/attachment.cgi?id=40506&action=review
------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
OK, spliting this a bit.
This just moves the code in EditorClientGtk.cpp to WebCore, but does not change
anything else. This code is only used when caret browse mode is enabled, which
only the GTK+ port does, so it should be totally safe (ie, no behavior change).
The extra editorCommands that are missing will be added when I add the
dumpEditorCommands stuff to our DRT, so that I'm able to test them :)
More information about the webkit-reviews
mailing list