[webkit-reviews] review denied: [Bug 29971] Clean up warnings in WebCore/bindings/v8/npruntime.cpp : [Attachment 40457] Path to get rid of warnings.

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Dave MacLachlan
<dmaclach at gmail.com>'s request for review:
Bug 29971: Clean up warnings in WebCore/bindings/v8/npruntime.cpp
https://bugs.webkit.org/show_bug.cgi?id=29971

Attachment 40457: Path to get rid of warnings.
https://bugs.webkit.org/attachment.cgi?id=40457&action=review

------- Additional Comments from David Levin <levin at chromium.org>
minor change log fixes suggested.

> Index: WebCore/ChangeLog
> +2009-10-01  Dave MacLachlan	<dmaclach at gmail.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
Add:
bug title
bug link
blank line
then your description.

> +	   Gets rid of warnings on gcc about using anonymous namespaces 
> +	     warning: 'StringKeyHashTraits' has a base
> +	    'WTF::GenericHashTraits<<unnamed>::StringKey>' 
> +	     whose type uses the anonymous namespace
> +	and

The spacing on this looks off. I think every in descriptions is indented beyond
this in the changelog.

> +	     warning: 'WTF::PairHashTraits<StringKeyHashTraits,
> +	     WTF::HashTraits<PrivateIdentifier*> >' has a base
> +	    'WTF::GenericHashTraits<std::pair<<unnamed>::StringKey,
> +	    PrivateIdentifier*> >' whose type uses the anonymous namespace
> +
> +	   No tests required.
> +
> +	   * bindings/v8/npruntime.cpp:
> +