[webkit-reviews] review requested: [Bug 29961] Position of "Close" button in docked mode doesn't match the position of window "Close" button in detached mode : [Attachment 40471] removed substring matching

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 1 12:51:41 PDT 2009


Mikhail Naganov <mnaganov at chromium.org> has asked  for review:
Bug 29961: Position of "Close" button in docked mode doesn't match the position
of window "Close" button in detached mode
https://bugs.webkit.org/show_bug.cgi?id=29961

Attachment 40471: removed substring matching
https://bugs.webkit.org/attachment.cgi?id=40471&action=review

------- Additional Comments from Mikhail Naganov <mnaganov at chromium.org>
For mac Inspector actually has "mac-tiger" and "mac-leopard", so my initial
intent was to merge these two cases into one (and also accept future
possibilities, like "mac-snow-leopard"). But if you insist on not using
substring matches, here is a plain version.

Doing a negation on more than one class selector isn't intuitive. I've done it
according to this W3C test:
http://www.w3.org/Style/CSS/Test/CSS3/Selectors/current/html/full/flat/css3-mod
sel-14e.html

I've checked that it works on Windows, and that after swapping these two :not's
button isn't get hidden, too.


More information about the webkit-reviews mailing list