[webkit-reviews] review denied: [Bug 29956] Math.random() gives too low values on Win32 when _CRT_RAND_S is not defined : [Attachment 40430] Patch which fixes the bug.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Jonni Rainisto
<jonni.rainisto at nokia.com>'s request for review:
Bug 29956: Math.random() gives too low values on Win32 when _CRT_RAND_S is not
defined
https://bugs.webkit.org/show_bug.cgi?id=29956

Attachment 40430: Patch which fixes the bug.
https://bugs.webkit.org/attachment.cgi?id=40430&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I think we need more bits of randomness. I'm not sure how many. It seems we are
using 32 bits of randomness in the first two cases, and 53 bits in the next
two. Having a Windows code path that uses only 30 bits seems wrong, but perhaps
the 32-bit ones are also wrong.

review- for now based on that issue, but I could be convinced I am wrong.