[webkit-reviews] review granted: [Bug 29952] Move RedirectScheduler to its own file : [Attachment 40425] Patch v1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 29952: Move RedirectScheduler to its own file
https://bugs.webkit.org/show_bug.cgi?id=29952

Attachment 40425: Patch v1
https://bugs.webkit.org/attachment.cgi?id=40425&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Normally in cases like this I start the new file with an svn copy of the large
file I am extracting it from.

I am disappointed we had to make so many FrameLoader internals public in order
to break this out! (But that was a comment on the earlier patch really, not
this one.)

> +	   void schedule(PassOwnPtr<ScheduledRedirection> redirection);

Should leave our argument here.

I think the RedirectScheduler is not well factored with respect to the frame
loader. It contains more of the logic than I would like that has nothing to do
with scheduling per se, which is why we end up exporting so many new functions
from FrameLoader.

But this is a noble effort, lets keep going and see where it leads.