[webkit-reviews] review denied: [Bug 29961] Position of "Close" button in docked mode doesn't match the position of window "Close" button in detached mode : [Attachment 40447] update patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 29961: Position of "Close" button in docked mode doesn't match the position
of window "Close" button in detached mode
https://bugs.webkit.org/show_bug.cgi?id=29961

Attachment 40447: update patch
https://bugs.webkit.org/attachment.cgi?id=40447&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +body.attached.platform-qt .toolbar-item[class*="close-"] {

It would be better and faster for the engine to write this as:

body.attached.platform-qt .toolbar-item.close-right, body.attached.platform-qt
.toolbar-item.close-left

Also more correct if we ever add somthing like "enclose-foo".

> +body[class*="platform-mac"] .toolbar-item.close-right { 

Should be: body.platform-mac .toolbar-item.close-right


> +body:not([class*="platform-mac"]) .toolbar-item.close-left { 

Should be: body:not(.platform-mac) .toolbar-item.close-left