[webkit-reviews] review denied: [Bug 26549] Web Inspector needs a testing infrastructure : [Attachment 40370] testing harness

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 26549: Web Inspector needs a testing infrastructure
https://bugs.webkit.org/show_bug.cgi?id=26549

Attachment 40370: testing harness
https://bugs.webkit.org/attachment.cgi?id=40370&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
Some tabs in evaluate-in-frontend.js.

> +	var output = document.getElementById("output");
> +    output.innerHTML += text + "<BR>";

Stray space.

> +    void testEvaluateInFrontend(long callId, const String& script);

These functions with "testEvaluate" read funny. I think "evaluateTest" would
read better. Since I read it as "evaluate this test", not "test the evaluate".

> +    Vector<pair<long, String> > m_pendingTestEvaluateInFrontendCommands;

Maybe m_pendingEvaluateTestCommands.