[webkit-reviews] review requested: [Bug 32005] Web Inspector: Escape key in the Search Field should be more User Friendly : [Attachment 44053] [PATCH] Desired Behavior

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 30 22:12:26 PST 2009


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 32005: Web Inspector: Escape key in the Search Field should be more User
Friendly
https://bugs.webkit.org/show_bug.cgi?id=32005

Attachment 44053: [PATCH] Desired Behavior
https://bugs.webkit.org/attachment.cgi?id=44053&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
previousFocusElement doesn't have a setter, and since this was the only special
case I didn't think it pertinent to add a setter. I also named the function as
descriptively as possible rather then searchOnMouseDown or something like we
normally do, again my reasoning being this is a special case and the name is
helpful.


More information about the webkit-reviews mailing list