[webkit-reviews] review granted: [Bug 31976] Update pywebsocket to 0.4.2.1 : [Attachment 44007] Update pywebsocket to 0.4.2.1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 30 16:31:03 PST 2009
Alexey Proskuryakov <ap at webkit.org> has granted Yuzo Fujishima
<yuzo at google.com>'s request for review:
Bug 31976: Update pywebsocket to 0.4.2.1
https://bugs.webkit.org/show_bug.cgi?id=31976
Attachment 44007: Update pywebsocket to 0.4.2.1
https://bugs.webkit.org/attachment.cgi?id=44007&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> + Update pywebsocket to 0.4.2.1.
Do we really need 4-digit version numbers for pywebsocket? I'm not sure if any
version numbers are needed at this point.
> + logging.error(
> + ('Exception in processing request from: %r' % (client_address,))
+
> + '\n' + util.get_stack_trace())
We don't usually wrap such short lines.
> + # Note: client_address is a tuple. To match it against %r, we need
the
> + # trailing comma.
Ditto.
r=me
More information about the webkit-reviews
mailing list