[webkit-reviews] review granted: [Bug 31885] Support reflections on composited layers : [Attachment 43871] Patch: part 1

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 31885: Support reflections on composited layers
https://bugs.webkit.org/show_bug.cgi?id=31885

Attachment 43871: Patch: part 1
https://bugs.webkit.org/attachment.cgi?id=43871&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    if (m_structuralLayer || m_contentsLayer || childLayers.size() > 0) {

In WebKit style we'd normally omit that "> 0".

> +	       updateLayerPosition();
> +	       updateLayerSize();
> +	       updateAnchorPoint();
> +	       updateTransform();
> +	       updateChildrenTransform();
>  
> +	       updateSublayerList();
> +	       updateOpacityOnLayer();

This is kind of funny -- and it's repeated more than once. Shouldn't this also
be calling updateLayerNames?

r=me