[webkit-reviews] review denied: [Bug 31604] WebSocket server should write errors to a log file : [Attachment 43898] Make pywebsocket log errors to a file

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Yuzo Fujishima <yuzo at google.com>'s
request for review:
Bug 31604: WebSocket server should write errors to a log file
https://bugs.webkit.org/show_bug.cgi?id=31604

Attachment 43898: Make pywebsocket log errors to a file
https://bugs.webkit.org/attachment.cgi?id=43898&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks OK, but why are we coyping this code from elsewhere?  It should be
abstracted into a sub routine.

I see this in the file already:

1380	    my $absTestResultsDirectory = File::Spec->rel2abs(glob
$testResultsDirectory);
1381	    my $sslCertificate = "$testDirectory/http/conf/webkit-httpd.pem";
1382	
1383	    mkpath $absTestResultsDirectory;