[webkit-reviews] review denied: [Bug 31953] [Qt] [code cleaning] Clean the code paths of QWebFrame::render() : [Attachment 43983] Check the view once.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Nov 29 07:43:19 PST 2009


Eric Seidel <eric at webkit.org> has denied Benjamin Poulain
<benjamin.poulain at nokia.com>'s request for review:
Bug 31953: [Qt] [code cleaning] Clean the code paths of QWebFrame::render()
https://bugs.webkit.org/show_bug.cgi?id=31953

Attachment 43983: Check the view once.
https://bugs.webkit.org/attachment.cgi?id=43983&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I'm not sure this is really any more clear.  Especially it seems kinda strange
to turn the if into an ASSERT in renderPrivate.

I'd be OK with this if you were just cleaning up render(4 args) as you have,
but it seems strange to change renderPrivate and rendner(QPainter*) too.


More information about the webkit-reviews mailing list