[webkit-reviews] review requested: [Bug 22250] PLATFORM(CAIRO) should be defined by WIN_CAIRO define : [Attachment 43988] proposed solution

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 28 19:14:39 PST 2009


Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 22250: PLATFORM(CAIRO) should be defined by WIN_CAIRO define
https://bugs.webkit.org/show_bug.cgi?id=22250

Attachment 43988: proposed solution
https://bugs.webkit.org/attachment.cgi?id=43988&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
Revision r45831 (http://trac.webkit.org/changeset/45831) - after this bug was
filed - essentially introduced a solution. WIN_CAIRO is defined by the build
system and can be used to detect the CAIRO build instead of the "blacklist"
approach currently used in Platform.h.

http://trac.webkit.org/changeset/45831 also defined WTF_PLATFORM_CAIRO in all
relevant config.h files (it is not needed in JavaScriptCore/config.h as
JavaScriptCore is not relying on the WTF_PLATFORM_CAIRO). The solution is to
simply remove this part from Platform.h.


More information about the webkit-reviews mailing list