[webkit-reviews] review requested: [Bug 31956] Move some build decisions from Qt build system into source files : [Attachment 43987] Respond to Kevin's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 28 17:45:40 PST 2009


Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 31956: Move some build decisions from Qt build system into source files
https://bugs.webkit.org/show_bug.cgi?id=31956

Attachment 43987: Respond to Kevin's comments
https://bugs.webkit.org/attachment.cgi?id=43987&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
Kevin, thanks for the comments. I removed the WX part from Platform.h - this
makes the patch even simpler.

I found ThreadingNone.cpp in JavaScriptCoreSources.bkl, this is why I though
the Wx port is using ThreadingNone.cpp. Is the JavaScriptCoreSources.bkl file
now obsolete ? 

As for JSC_MULTIPLE_THREADS for wx, can you please file a separate patch for
that ?


More information about the webkit-reviews mailing list