[webkit-reviews] review granted: [Bug 31939] style-queue should only process each patch once : [Attachment 43965] initial status
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 27 15:27:22 PST 2009
Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 31939: style-queue should only process each patch once
https://bugs.webkit.org/show_bug.cgi?id=31939
Attachment 43965: initial status
https://bugs.webkit.org/attachment.cgi?id=43965&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
.cached_scm was a name from a naiver time. :) I think we shoudl just call it
._scm now.
I feel like PatchCollection hasn't quite figured out what it is yet. :( Part
of me thinks we shoudl make somethign that works perfectly for hte style queue
and worry about abstracting it later, since I had to rip PatchCollection out of
commit-queue already. :(
Looks OK though. I'd prefer we went with _scm and _statusbot though.
More information about the webkit-reviews
mailing list