[webkit-reviews] review requested: [Bug 29912] Avoid zero division during SVGPaintServerPattern::setup() : [Attachment 43968] LayoutTest for SVG pattern crash

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 27 13:30:28 PST 2009


Dirk Schulze <krit at webkit.org> has asked  for review:
Bug 29912: Avoid zero division during SVGPaintServerPattern::setup()
https://bugs.webkit.org/show_bug.cgi?id=29912

Attachment 43968: LayoutTest for SVG pattern crash
https://bugs.webkit.org/attachment.cgi?id=43968&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
This patch includes a test case for the bug.

Luckily I was wrong and the previous patch did not break the mentioned test
(stroked-pattern.svg) or the one of batik.

This crash is still a general issue and happens if the pattern size is smaller
than the tile of the pattern and the attribute overview is set to visible. Also
the pattern size must be smaller than 0.5 in any dimension.

I would suggest to review "Proposed fix for a Chromium SVG crash" again with
this patch as Layouttest.


More information about the webkit-reviews mailing list