[webkit-reviews] review denied: [Bug 31921] Use ProgressTracker from the inspected page to generate ids for cached resources : [Attachment 43937] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 27 01:36:39 PST 2009


Pavel Feldman <pfeldman at chromium.org> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 31921: Use ProgressTracker from the inspected page to generate ids for
cached resources
https://bugs.webkit.org/show_bug.cgi?id=31921

Attachment 43937: patch
https://bugs.webkit.org/attachment.cgi?id=43937&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
I don't think we need to add methods for setting various integers - we don't
even use existing ones. Can we optimize it in a way that there are only methods
for signed, unsigned and floating point? That API would be easier to maintain
and there will not be that much copy-paste in the code.


More information about the webkit-reviews mailing list