[webkit-reviews] review requested: [Bug 25415] [GTK][ATK] Please implement support for get_text_at_offset : [Attachment 43935] Comment 57 fix with unit tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 26 21:30:23 PST 2009


Joanmarie Diggs <joanmarie.diggs at gmail.com> has asked  for review:
Bug 25415: [GTK][ATK] Please implement support for get_text_at_offset
https://bugs.webkit.org/show_bug.cgi?id=25415

Attachment 43935: Comment 57 fix with unit tests
https://bugs.webkit.org/attachment.cgi?id=43935&action=review

------- Additional Comments from Joanmarie Diggs <joanmarie.diggs at gmail.com>
This is essentially the same fix as I originally proposed for the issue. The
only different in the fix is adding a check to be sure we have wrapped text
before eliminating the final character on the line.

This patch also adds two more unit tests.


More information about the webkit-reviews mailing list