[webkit-reviews] review granted: [Bug 28631] Chromium Linux: don't stretch checkboxes : [Attachment 43820] html cleanup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 26 21:17:30 PST 2009


Eric Seidel <eric at webkit.org> has granted Evan Stade <estade at chromium.org>'s
request for review:
Bug 28631: Chromium Linux: don't stretch checkboxes
https://bugs.webkit.org/show_bug.cgi?id=28631

Attachment 43820: html cleanup
https://bugs.webkit.org/attachment.cgi?id=43820&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I'm not a big fan of the name "center", but I'm not sure I have a better
suggestion.  The patch looks fine.  We'll need results for other platforms. 
I'm surprised that this isn't already covered by other tests.

Also, WebKit has no firm wrapping rule:
+	 Make the default size for checkboxes/radio buttons also the maximum
+	 size.

We generally just wrap when it's convenient. :)


More information about the webkit-reviews mailing list