[webkit-reviews] review granted: [Bug 31904] [bzt] Kill WebKitLandingScripts : [Attachment 43904] Step 4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 26 20:25:38 PST 2009


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 31904: [bzt] Kill WebKitLandingScripts
https://bugs.webkit.org/show_bug.cgi?id=31904

Attachment 43904: Step 4
https://bugs.webkit.org/attachment.cgi?id=43904&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Commands already have a self.tool now.	No need to pass tool:
	 self._create_changelogs_for_revert(tool.scm(), revision)
 398	     self._create_changelogs_for_revert(tool, revision)

If you're going to move away from scm(), we should move to self.tool


More information about the webkit-reviews mailing list