[webkit-reviews] review granted: [Bug 31538] Web Inspector: Wrong console output for Regexp escape sequence : [Attachment 43896] [PATCH] Desired Behavior + Some Refactoring

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 31538: Web Inspector: Wrong console output for Regexp escape sequence
https://bugs.webkit.org/show_bug.cgi?id=31538

Attachment 43896: [PATCH] Desired Behavior + Some Refactoring
https://bugs.webkit.org/attachment.cgi?id=43896&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
This looks right, although lots of changes. But I think you covered pretty much
everything with the tests, so we are safe!

> +    globals = [regex1, regex2, str, error, node, func, multilinefunc, num,
linkify, undefined];

Could you please add null to the list?

> +	   for (var i = 0; i < parameters.length; ++i)
>	       if (typeof parameters[i] !== "object" && typeof parameters[i]
!== "function")
>		   parameters[i] =
WebInspector.ObjectProxy.wrapPrimitiveValue(parameters[i]);
> -	   }

I think we use {} for more-than-one-line blocks even if that is single
statement. No?