[webkit-reviews] review requested: [Bug 31538] Web Inspector: Wrong console output for Regexp escape sequence : [Attachment 43895] [PATCH] Desired Behavior + Some Refactoring

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 31538: Web Inspector: Wrong console output for Regexp escape sequence
https://bugs.webkit.org/show_bug.cgi?id=31538

Attachment 43895: [PATCH] Desired Behavior + Some Refactoring
https://bugs.webkit.org/attachment.cgi?id=43895&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
This is another step in the right direction.  This patch includes:

  - a bunch of style fixes / improvements to ConsoleView
  - simplification and clarification of the current _format flow
  - the same test as before but without the Date test

Because the patch is difficult to read. Here is a better view of the
reformulated _format functions:

  - ConsoleView's _format (dispatch to formatter):
    http://pastie.textmate.org/private/celurrgbupm5jvxu2hg

  - ConsoleMessage's _format (workflow) => 
    http://pastie.textmate.org/private/i0o8w6uuj2khupo4bwdrkg

Issues I have:

  - test output of linkify doesn't show that the output is a link? I may have
to use something other then dumpMessages
  - test output contains quotes around text that doesn't appear in manual
console tests.
  - again, I cannot find a case for _formaterror and it was removed. Could it
happen?

Next Steps:

  - remove the hack I made checking for this.originatingCommand. Meaning we
should separate handling of user eval'd commands in a better way or provide a
more concerete way to check for this. (Maybe yet another parameter in the
constructor?)