[webkit-reviews] review denied: [Bug 11049] XMLHttpRequest always defaults Content-Type to application/xml, while it should depend on data type : [Attachment 42613] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 25 22:11:21 PST 2009


Eric Seidel <eric at webkit.org> has denied Carol Szabo <carol.szabo at nokia.com>'s
request for review:
Bug 11049: XMLHttpRequest always defaults Content-Type to application/xml,
while it should depend on data type
https://bugs.webkit.org/show_bug.cgi?id=11049

Attachment 42613: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=42613&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
The test could be made much better using shouldBe.  Or at least something which
checks the expected value against the expected instead of requiring visual
inspection.

Is this covered by any spec?  if so, that should be listed in the Changelog. 
Likewise the ChangeLog should mention if this brings us closer or further from
FF/IE's behavior.


More information about the webkit-reviews mailing list