[webkit-reviews] review denied: [Bug 31877] [v8] Do not check the thread when accessing DOMDataStore : [Attachment 43854] Cosmetic improvements
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 25 10:34:26 PST 2009
Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied anton muhin
<antonm at chromium.org>'s request for review:
Bug 31877: [v8] Do not check the thread when accessing DOMDataStore
https://bugs.webkit.org/show_bug.cgi?id=31877
Attachment 43854: Cosmetic improvements
https://bugs.webkit.org/attachment.cgi?id=43854&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/bindings/v8/V8DOMMap.cpp
...
> +namespace {
> +
> +static inline DOMDataStore& getDOMDataStore()
> +{
> + ASSERT(WTF::isMainThread()); // As of now, we must be always on the
main thread.
> + return MainThreadDOMData::getCurrentMainThreadStore();
> +}
> +
> +}
nit: The anonymous namespace is redundant. A static function already has
internal linkage. I would just delete the anonymous namespace.
More information about the webkit-reviews
mailing list