[webkit-reviews] review denied: [Bug 31873] [V8] Avoid using JavaScript objects as context data : [Attachment 43847] Use string instead if JavaScript object for context "data"
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 25 08:40:13 PST 2009
Pavel Feldman <pfeldman at chromium.org> has denied Søren Gjesse
<sgjesse at chromium.org>'s request for review:
Bug 31873: [V8] Avoid using JavaScript objects as context data
https://bugs.webkit.org/show_bug.cgi?id=31873
Attachment 43847: Use string instead if JavaScript object for context "data"
https://bugs.webkit.org/attachment.cgi?id=43847&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> -const char* V8Proxy::kContextDebugDataType = "type";
> -const char* V8Proxy::kContextDebugDataValue = "value";
Remove these from .h as well? Otherwise r+.
More information about the webkit-reviews
mailing list