[webkit-reviews] review denied: [Bug 18282] WebKit crashes with deeply nested divs : [Attachment 43803] Patch providing an optional maximum depth cap to the DOM tree, enabled using --enable-domtree-maxdepth

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Keith Kyzivat <kkyzivat at ovi.com>'s
request for review:
Bug 18282: WebKit crashes with deeply nested divs
https://bugs.webkit.org/show_bug.cgi?id=18282

Attachment 43803: Patch providing an optional maximum depth cap to the DOM
tree, enabled using --enable-domtree-maxdepth
https://bugs.webkit.org/attachment.cgi?id=43803&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Can't commit with "OOPS" in a ChangeLog.  The "Reviewed by" line will be fixed
by our landing scripts, but:
No new tests. (OOPS!)
will cause the commit to fail.

The parsing case could be made quick by caching the current level of the parse
tree.

I'm not sure I'm a big fan of this change, but I don't really know what to
suggest.

r- because the ChangeLog would cause the commit to fail.

Testing for this is easy.  There should be a test which validates that we can't
add below 400 items.  Obviously that test only makes sense if this feature is
enabled, and would probably be skipped on all platforms except whichever plans
to use this.

Speakign of which, what platform would use this?