[webkit-reviews] review granted: [Bug 31831] [Android] The select elements do not reflect the actual choice the user makes. : [Attachment 43846] Handle the drawing of ListBoxes in Android code. Also fix exisiting style issues.

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Andrei Popescu
<andreip at google.com>'s request for review:
Bug 31831: [Android] The select elements do not reflect the actual choice the
user makes.
https://bugs.webkit.org/show_bug.cgi?id=31831

Attachment 43846: Handle the drawing of ListBoxes in Android code. Also fix
exisiting style issues.
https://bugs.webkit.org/attachment.cgi?id=43846&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Thanks for cleaning up the old code!

r=me, except:

>  bool RenderThemeAndroid::paintTextArea(RenderObject* obj, const
RenderObject::PaintInfo& info, const IntRect& rect)
>  {
> -    if (obj->isMenuList())
> -	   return paintCombo(obj, info, rect);
> +    if (obj->isListBox()) {
> +	   paintCombo(obj, info, rect);

Can this be just an early return?