[webkit-reviews] review granted: [Bug 31870] Add OutputCaputure class for sharing capture_output between unit tests : [Attachment 43841] Abstract out capturing stdout/stderr into a new OutputCapture class for re-use among the various unit tests.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 25 07:28:22 PST 2009


Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 31870: Add OutputCaputure class for sharing capture_output between unit
tests
https://bugs.webkit.org/show_bug.cgi?id=31870

Attachment 43841: Abstract out capturing stdout/stderr into a new OutputCapture
class for re-use among the various unit tests.
https://bugs.webkit.org/attachment.cgi?id=43841&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Looks good.  I had sketched this out as a base class, but compositing is
better.


More information about the webkit-reviews mailing list